Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ALL DEFERRED #148

Merged
merged 3 commits into from
Jun 25, 2024
Merged

add ALL DEFERRED #148

merged 3 commits into from
Jun 25, 2024

Conversation

sjib
Copy link
Contributor

@sjib sjib commented Jun 17, 2024

@sjib sjib added the enhancement New feature or request label Jun 17, 2024
@sjib sjib self-assigned this Jun 17, 2024
@sjib sjib added this to the 1.6.2 - 2024.0 milestone Jun 17, 2024
@ponceta ponceta closed this Jun 18, 2024
@ponceta ponceta reopened this Jun 18, 2024
@sjib
Copy link
Contributor Author

sjib commented Jun 19, 2024 

File "/home/runner/work/qgepqwat2ili/qgepqwat2ili/qgepqwat2ili/__init__.py", line 207, in main
    qgepsia405_export(selection=args.selection.split(",") if args.selection else None, labels_file=args.labels_file, orientation=args.labels_orientation)
  File "/home/runner/work/qgepqwat2ili/qgepqwat2ili/qgepqwat2ili/qgepsia405/export.py", line 33, in qgep_export
    abwasser_session.execute(text("SET CONSTRAINTS ALL DEFERRED;"))
NameError: name 'text' is not defined

@sjib
Copy link
Contributor Author

sjib commented Jun 19, 2024

missing library added: from sqlalchemy.sql import text

@sjib
Copy link
Contributor Author

sjib commented Jun 19, 2024

@ponceta Now it seems to be ok - ready for review and merging

@sjib sjib requested a review from ponceta June 19, 2024 14:36
@ponceta ponceta merged commit 9416466 into master Jun 25, 2024
4 checks passed
@ponceta ponceta deleted the 2024-06-17-abwasser_session-add-ALL-DEFERRE branch June 25, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ponceta ponceta ponceta approved these changes

Assignees

@sjib sjib

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.6.2 - 2024.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sjib @ponceta